Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/vm: clean up contract creation error handling #22766

Merged
merged 1 commit into from
May 1, 2021

Conversation

chfast
Copy link
Member

@chfast chfast commented Apr 29, 2021

Do not keep separate flag for "max code size exceeded" case, but instead
assign appropriate error for it sooner.

Do not keep separate flag for "max code size exceeded" case, but instead
assign appropriate error for it sooner.
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm!

@fjl fjl changed the title evm: Clean up contract creation error handling core/vm: clean up contract creation error handling Apr 30, 2021
@fjl fjl merged commit 0e00ee4 into ethereum:master May 1, 2021
@chfast chfast deleted the evm_create_error_handling branch May 1, 2021 14:23
@karalabe karalabe modified the milestone: 1.10.4 May 5, 2021
atif-konasl pushed a commit to frozeman/pandora-execution-engine that referenced this pull request Oct 15, 2021
Do not keep separate flag for "max code size exceeded" case, but instead
assign appropriate error for it sooner.
yperbasis added a commit to erigontech/erigon that referenced this pull request Dec 30, 2022
Cherry-pick ethereum/go-ethereum#22766.

Do not keep separate flag for "max code size exceeded" case, but instead
assign appropriate error for it sooner.

Co-authored-by: Paweł Bylica <chfast@gmail.com>
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Mar 1, 2024
Do not keep separate flag for "max code size exceeded" case, but instead
assign appropriate error for it sooner.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants