Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: return new HTTPError type for HTTP error responses #22677

Merged
merged 3 commits into from
Apr 21, 2021

Conversation

ryanc414
Copy link
Contributor

@ryanc414 ryanc414 commented Apr 15, 2021

New error type holds details of the specific error code and response
body.

Closes #22654

@ryanc414 ryanc414 requested review from fjl and holiman as code owners April 15, 2021 15:33
@fjl fjl changed the title rpc: Return new HTTPError type for HTTP error responses rpc: return new HTTPError type for HTTP error responses Apr 15, 2021
@fjl fjl added this to the 1.10.3 milestone Apr 15, 2021
@fjl fjl self-assigned this Apr 15, 2021
Ryan Collingham and others added 3 commits April 21, 2021 14:55
@fjl fjl force-pushed the rlc/http-error branch from 34fb08b to f02ed52 Compare April 21, 2021 12:55
@fjl fjl removed their assignment Apr 21, 2021
@fjl fjl merged commit 9357280 into ethereum:master Apr 21, 2021
@ryanc414 ryanc414 deleted the rlc/http-error branch April 21, 2021 14:18
atif-konasl pushed a commit to frozeman/pandora-execution-engine that referenced this pull request Oct 15, 2021
The new error type is returned by client operations contains details of
the response error code and response body.

Co-authored-by: Felix Lange <fjl@twurst.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return more metadata for HTTP errors
2 participants