Skip to content

Conversation

@karalabe
Copy link
Member

No description provided.

@karalabe karalabe added this to the 1.9.20 milestone Aug 25, 2020
Copy link
Member

@rjl493456442 rjl493456442 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@karalabe karalabe merged commit 63a9d4b into ethereum:master Aug 25, 2020
@sidhujag
Copy link

sidhujag commented Aug 27, 2020

Did you guys have a policy around this, for example on rinkeby that block was roughly 60-65k blocks deep when it was CHT'd is that safe (1 week old checkpoint)? Generally I would recommend 3 weeks at minimum for re-org security. In bitcoin the checkpoints are generally added atleast many months old.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants