Skip to content

cmd, eth: fix dump config issue. #19825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 11, 2019
Merged

cmd, eth: fix dump config issue. #19825

merged 2 commits into from
Jul 11, 2019

Conversation

rjl493456442
Copy link
Member

Fixes #19824

@rjl493456442 rjl493456442 mentioned this pull request Jul 11, 2019
Closed
karalabe
karalabe approved these changes Jul 11, 2019
View reviewed changes
Copy link
Member

@karalabe karalabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karalabe karalabe added this to the 1.9.1 milestone Jul 11, 2019
@karalabe
Copy link
Member

Good catch on the datadir!

@karalabe karalabe merged commit 2521509 into ethereum:master Jul 11, 2019
@karalabe karalabe mentioned this pull request Jul 17, 2019
Closed
@rjl493456442 rjl493456442 mentioned this pull request Jul 19, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karalabe karalabe karalabe approved these changes

@holiman holiman Awaiting requested review from holiman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.9.1
Development

Successfully merging this pull request may close these issues.

[1.9] dumpconfig throwing error "nil *params.TrustedCheckpoint"
2 participants
@rjl493456442 @karalabe