Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: replace fmt.Print* calls with t.Log* in tests #19670

Merged
merged 9 commits into from
Jul 17, 2019
Merged

all: replace fmt.Print* calls with t.Log* in tests #19670

merged 9 commits into from
Jul 17, 2019

Conversation

Shitaibin
Copy link
Contributor

This PR is attampt to replace fmt.Print* to t.Log* in tests or b.Log* in benchmark. Here are the details:

  • fmt.Printf -> t.Logf or b.Logf
  • fmt.Println -> t.Log or b.Log

@Shitaibin Shitaibin changed the title Replace fmt.Print* functions to t.Log* in all tests cmd, signer, crypto, core, les, p2p, eth: Replace fmt.Print* functions to t.Log* in all tests Jun 5, 2019
@fjl fjl self-assigned this Jun 6, 2019
@fjl fjl changed the title cmd, signer, crypto, core, les, p2p, eth: Replace fmt.Print* functions to t.Log* in all tests all: replace fmt.Print* calls with t.Log* in tests Jul 17, 2019
@fjl fjl merged commit 4ac04ae into ethereum:master Jul 17, 2019
@fjl
Copy link
Contributor

fjl commented Jul 17, 2019

Thank you!

@fjl fjl mentioned this pull request Jul 17, 2019
Merged
@gzliudan gzliudan mentioned this pull request Mar 14, 2024
Merged
19 tasks
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Mar 18, 2024
@gzliudan
eth/filters: replace fmt.Println with b.Log in tests (ethereum#19670)
7cffa1d
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Nov 29, 2024
@gzliudan
crypto: replace fmt.Println calls with t.Log in tests (ethereum#19670)
d306023
@gzliudan gzliudan mentioned this pull request Nov 29, 2024
Merged
19 tasks
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Dec 2, 2024
@gzliudan
crypto: replace fmt.Println calls with t.Log in tests (ethereum#19670)
e07d304
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Dec 2, 2024
@gzliudan
crypto: replace fmt.Println calls with t.Log in tests (ethereum#19670)
8846268
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Dec 4, 2024
@gzliudan
crypto: replace fmt.Println calls with t.Log in tests (ethereum#19670)
cbb7474
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Dec 9, 2024
@gzliudan
crypto: replace fmt.Println calls with t.Log in tests (ethereum#19670)
b9054b2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjl fjl fjl approved these changes

@holiman holiman Awaiting requested review from holiman holiman is a code owner

@karalabe karalabe Awaiting requested review from karalabe

@rjl493456442 rjl493456442 Awaiting requested review from rjl493456442 rjl493456442 is a code owner

@zsfelfoldi zsfelfoldi Awaiting requested review from zsfelfoldi zsfelfoldi is a code owner

Assignees

@fjl fjl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Shitaibin @fjl