accounts, cmd, internal, signer: add note about backing up the keystore #19432

kurkomisi · 2019-04-10T08:04:29Z

Fixes #19165

Running geth account new:

Your new account is locked with a password. Please give a password. Do not forget this password.
Passphrase: 
Repeat passphrase: 
Your new key was generated
Address: {adbb1348ab38e354ca79f7284701d701d02b351c}
Please backup your key file!
Path:    {/home/user/.ethereum/keystore/UTC--2019-04-25T11-07-21.800464724Z--adbb1348ab38e354ca79f7284701d701d02b351c}
Please remember your password!

In geth console running personal.newAccount():

Passphrase: 
Repeat passphrase: 
INFO [04-25|13:53:24.946] Your new key was generated               address=0xbD8603B63EaC7633987e1F331D542a5e99dA4418
WARN [04-25|13:53:24.946] Please backup your key file!             path=/home/user/.ethereum/rinkeby/keystore/UTC--2019-04-25T10-53-23.649181805Z--bd8603b63eac7633987e1f331d542a5e99da4418
WARN [04-25|13:53:24.946] Please remember your password! 
"0xbd8603b63eac7633987e1f331d542a5e99da4418"

clef:

curl -H "Content-Type: application/json" -X POST --data "{\"jsonrpc\":\"2.0\",\"method\":\"account_new\", \"id\":67}" http://localhost:8550/

-------- New Account request--------------

A request has been made to create a new account. 
Approving this operation means that a new account is created,
and the address is returned to the external caller

Request context:
	127.0.0.1:58370 -> HTTP/1.1 -> localhost:8550

Additional HTTP header data, provided by the external caller:
	User-Agent: curl/7.58.0
	Origin: 
Approve? [y/N]:
> y
## New account password

Please enter a password for the new account to be created (attempt 0 of 3)
> -----------------------
INFO [04-25|13:59:59.010] Your new key was generated               address=0xD84f83cdf440061b7259dCb1EC39b83B747836C6
WARN [04-25|13:59:59.010] Please backup your key file!             path=/home/user/.ethereum/keystore/UTC--2019-04-25T10-59-57.750166407Z--d84f83cdf440061b7259dcb1ec39b83b747836c6
WARN [04-25|13:59:59.010] Please remember your password!

holiman · 2019-04-10T08:32:13Z

accounts/keystore/key.go

@@ -179,6 +179,8 @@ func storeNewKey(ks keyStore, rand io.Reader, auth string) (*Key, accounts.Accou
 		zeroKey(key.PrivateKey)
 		return nil, a, err
 	}
+	fmt.Printf("Your new key is generated. Please backup the key file: %s\n", a.URL)


This is used from other locations aswell, we shouldn't fmt.Printf from within a lower library. If you modify StoreKey instead, which is only called from accountCreate, then you can pick out the URL from the returned account, and either do the printout there, or -- better, return the entire account instead of just the address

I returned the entire account instead of just the address.

holiman · 2019-04-10T09:37:33Z

Looks good. Now please add a log info message for server side when new account is created via rpc aswell

holiman

LGTM

karalabe · 2019-04-25T10:04:56Z

internal/ethapi/api.go

@@ -295,6 +295,7 @@ func (s *PrivateAccountAPI) DeriveAccount(url string, path string, pin *bool) (a
 func (s *PrivateAccountAPI) NewAccount(password string) (common.Address, error) {
 	acc, err := fetchKeystore(s.am).NewAccount(password)
 	if err == nil {
+		log.Info("Your new key is generated. Please backup the key file", "path", acc.URL.Path)


Nit, logs should be shorter than 40 character to keep them aligned. Perhaps let's split there into 3? cc @holiman ?

log.Info("Your new key was generated", "address", /* dunno what goes here */) log.Warn("Please backup your key file!", "path", acc.URL.Path) log.Warn("Please remember your password!")

Warn makes sure it's a bit more visible. Open for opposition.

If we do go down this path, do it for the other occurrences too.

Sure, sounds good

karalabe

LGTM

karalabe · 2019-05-07T08:38:32Z

@kurkomisi Fix the tests please, and run the test suite next time before opening a PR.

holiman · 2019-05-07T08:38:38Z

--- FAIL: TestAccountNew (0.20s)
	test_cmd.go:250: (stderr) INFO [04-25|11:15:51.118] Bumping default cache on mainnet         provided=1024 updated=4096
	test_cmd.go:250: (stderr) WARN [04-25|11:15:51.118] Sanitizing cache to Go's GC limits       provided=4096 updated=2490
	test_cmd.go:250: (stderr) INFO [04-25|11:15:51.120] Maximum peer count                       ETH=25 LES=0 total=25
	test_cmd.go:114: Matched stdout text:
		Your new account is locked with a password. Please give a password. Do not forget this password.
		!! Unsupported terminal, password will be echoed.
		Passphrase: 
		Repeat passphrase: 
	test_cmd.go:162: Matched stdout text:
		Your new key was generated
		Address: {42c3a86b03684333096b6ceee843e89e4a317bba}
		Ple
	test_cmd.go:183: Unmatched stdout text:
		ase backup your key file!
		Path:    {/tmp/geth-test847508519/keystore/UTC--2019-04-25T11-15-51.121447117Z--42c3a86b03684333096b6ceee843e89e4a317bba}
		Please remember your password!

finleyexp · 2021-02-09T23:52:07Z

How do you backup the keystore file? Every where I go it says "backup keystore" but nowhere does it say "use these steps to backup keystore". I've looked in the Geth tuts:

https://geth.ethereum.org/docs/interface/mining
https://geth.ethereum.org/docs/interface/command-line-options
https://ethereum.org/en/developers/tutorials/run-light-node-geth/

holiman reviewed Apr 10, 2019

View reviewed changes

kurkomisi force-pushed the keystore-backup-message branch 2 times, most recently from 7529fb7 to 0e076a0 Compare April 10, 2019 09:22

kurkomisi changed the title ~~accounts: add note about backing up the keystore~~ accounts, cmd: add note about backing up the keystore Apr 10, 2019

kurkomisi force-pushed the keystore-backup-message branch from 0e076a0 to 7d79fa1 Compare April 15, 2019 12:06

kurkomisi requested a review from karalabe as a code owner April 15, 2019 12:06

kurkomisi changed the title ~~accounts, cmd: add note about backing up the keystore~~ accounts, cmd, internal, signer: add note about backing up the keystore Apr 15, 2019

kurkomisi requested a review from holiman April 15, 2019 12:30

kurkomisi added this to the 1.9.0 milestone Apr 25, 2019

holiman approved these changes Apr 25, 2019

View reviewed changes

karalabe reviewed Apr 25, 2019

View reviewed changes

Kurkó Mihály added 4 commits April 25, 2019 13:52

accounts: add note about backing up the keystore

d6d3bde

cmd, accounts: move the printout to accountCreate

e3f18d4

internal, signer: add info when new account is created via rpc

8c4002c

cmd, internal, signer: split logs

88c6ffd

kurkomisi force-pushed the keystore-backup-message branch from 7d79fa1 to 88c6ffd Compare April 25, 2019 11:11

adamschmideg added the status:triage label May 7, 2019

karalabe approved these changes May 7, 2019

View reviewed changes

holiman approved these changes May 7, 2019

View reviewed changes

cmd/geth: make account new output a bit more verbose

6971951

karalabe removed the status:triage label May 7, 2019

karalabe mentioned this pull request May 7, 2019

cmd/geth: add note about backing up the keystore #19165

Closed

karalabe merged commit 107c67d into ethereum:master May 7, 2019

gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jan 2, 2025

accounts, cmd: add note about backing up the keystore (ethereum#19432)

d95be01

gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jan 3, 2025

accounts, cmd: add note about backing up the keystore (ethereum#19432)

34171cd

gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jan 4, 2025

accounts, cmd: add note about backing up the keystore (ethereum#19432)

8453084

gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jan 6, 2025

accounts, cmd: add note about backing up the keystore (ethereum#19432)

6ab5193

gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jan 7, 2025

accounts, cmd: add note about backing up the keystore (ethereum#19432)

f0bdbdb

gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jan 7, 2025

accounts, cmd: add note about backing up the keystore (ethereum#19432)

79dfaba

gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jan 7, 2025

accounts, cmd: add note about backing up the keystore (ethereum#19432)

8b0ffe4

gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jan 9, 2025

accounts, cmd: add note about backing up the keystore (ethereum#19432)

82dae4e

gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jan 10, 2025

accounts, cmd: add note about backing up the keystore (ethereum#19432)

4b783ea

gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jan 10, 2025

accounts, cmd: add note about backing up the keystore (ethereum#19432)

ef7e71a

gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jan 14, 2025

accounts, cmd: add note about backing up the keystore (ethereum#19432)

8d355ac

gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jan 16, 2025

accounts, cmd: add note about backing up the keystore (ethereum#19432)

5fb0767

gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jan 17, 2025

accounts, cmd: add note about backing up the keystore (ethereum#19432)

a276c3f

gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jan 22, 2025

accounts, cmd: add note about backing up the keystore (ethereum#19432)

a1ab669

gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jan 22, 2025

accounts, cmd: add note about backing up the keystore (ethereum#19432)

38c8c30

gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jan 23, 2025

accounts, cmd: add note about backing up the keystore (ethereum#19432)

580db33

gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jan 24, 2025

accounts, cmd: add note about backing up the keystore (ethereum#19432)

fa35614

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

accounts, cmd, internal, signer: add note about backing up the keystore #19432

accounts, cmd, internal, signer: add note about backing up the keystore #19432

kurkomisi commented Apr 10, 2019 •

edited

Loading

holiman Apr 10, 2019

kurkomisi Apr 10, 2019

holiman commented Apr 10, 2019

holiman left a comment

karalabe Apr 25, 2019 •

edited

Loading

karalabe Apr 25, 2019

holiman Apr 25, 2019

karalabe left a comment

karalabe commented May 7, 2019

holiman commented May 7, 2019 •

edited

Loading

finleyexp commented Feb 9, 2021 •

edited

Loading

accounts, cmd, internal, signer: add note about backing up the keystore #19432

accounts, cmd, internal, signer: add note about backing up the keystore #19432

Conversation

kurkomisi commented Apr 10, 2019 • edited Loading

holiman Apr 10, 2019

Choose a reason for hiding this comment

kurkomisi Apr 10, 2019

Choose a reason for hiding this comment

holiman commented Apr 10, 2019

holiman left a comment

Choose a reason for hiding this comment

karalabe Apr 25, 2019 • edited Loading

Choose a reason for hiding this comment

karalabe Apr 25, 2019

Choose a reason for hiding this comment

holiman Apr 25, 2019

Choose a reason for hiding this comment

karalabe left a comment

Choose a reason for hiding this comment

karalabe commented May 7, 2019

holiman commented May 7, 2019 • edited Loading

finleyexp commented Feb 9, 2021 • edited Loading

kurkomisi commented Apr 10, 2019 •

edited

Loading

karalabe Apr 25, 2019 •

edited

Loading

holiman commented May 7, 2019 •

edited

Loading

finleyexp commented Feb 9, 2021 •

edited

Loading