Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth/downloader: SetBlocksIdle is not used #17962

Merged
merged 1 commit into from
Oct 23, 2018

Conversation

jsvisa
Copy link
Contributor

@jsvisa jsvisa commented Oct 23, 2018

No description provided.

@jsvisa jsvisa requested a review from karalabe as a code owner October 23, 2018 14:28
fjl
fjl previously approved these changes Oct 23, 2018
Copy link
Contributor

@fjl fjl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@fjl fjl dismissed their stale review October 23, 2018 16:16

Please fix the import cycle

@fjl
Copy link
Contributor

fjl commented Oct 23, 2018

Sorry, just noticed that the CI error is not your fault. It is fixed in #17965, we can merge after that.

@jsvisa
Copy link
Contributor Author

jsvisa commented Oct 23, 2018

Thanks for your quick reply, it doesn't matter 🍺

@fjl fjl merged commit 6810933 into ethereum:master Oct 23, 2018
@jsvisa jsvisa deleted the feat_peer_delete_SetBlocksIdle branch October 24, 2018 10:55
@karalabe karalabe added this to the 1.8.18 milestone Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants