Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/clef: added more details to the clef tutorial #17759

Merged
merged 2 commits into from
Sep 26, 2018
Merged

cmd/clef: added more details to the clef tutorial #17759

merged 2 commits into from
Sep 26, 2018

Conversation

PaulRBerg
Copy link
Contributor

  • Explained that rules are not mandatory
  • Added more guidance on the account, i.e. a normal geth configuration can be used but you have to mind using the same datadir
  • Updated the logs to reflect the latest api versions (2.0.0 instead of 1.2.0)
  • Minor helping snippets such as the mentioning of openssl sha256

@PaulRBerg PaulRBerg mentioned this pull request Sep 25, 2018
Closed
@fjl fjl changed the title Added more details to the clef tutorial cmd/clef: added more details to the clef tutorial Sep 25, 2018
holiman
holiman approved these changes Sep 25, 2018
View reviewed changes
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for updating this!

I left some comments, you can update the ones you think are relevant

cmd/clef/tutorial.md Outdated Show resolved Hide resolved
cmd/clef/tutorial.md Outdated Show resolved Hide resolved
cmd/clef/tutorial.md Outdated Show resolved Hide resolved
@holiman holiman merged commit bf411a0 into ethereum:master Sep 26, 2018
@PaulRBerg PaulRBerg deleted the clef_additions branch October 15, 2018 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holiman holiman holiman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PaulRBerg @holiman