eth: fix tracer panic when running without configs + reexec #15799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjl
approved these changes
Jan 4, 2018
cooganb
referenced
this pull request
in cooganb/go-ethereum
Jan 23, 2018
cooganb
referenced
this pull request
in cooganb/go-ethereum
Feb 23, 2018
mariameda
pushed a commit
to NiluPlatform/go-nilu
that referenced
this pull request
Aug 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fancy tracer PR added a new functionality to reexecute a number of historical blocks for a trace if the state is missing for the requested entity (block, chain, tx). This is 128 by default but can be explicitly set via a tracer config field.
Currently there's a
nilpointer panic in the old raw tracer because that one does not have aconfigparameter at all, but the tracing code still pokes aroundconfig.Reexec. This PR fixes it by checking first whether the config parameter itself was set before trying to poke around its fields.