Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid params error expected on nil Withdrawals in engine_newPayloadV2 #26604

Closed
marioevz opened this issue Feb 3, 2023 · 1 comment
Closed
Assignees
Labels

Comments

@marioevz
Copy link
Member

marioevz commented Feb 3, 2023

System information

Geth version: Geth/v1.11.0-unstable-3a79a99f-20230203/linux-amd64/go1.19.5
CL client & version: ethereum/hive/pull/700
OS & Version: Linux
Commit hash : 3a79a99

Expected behavior

-32602: Invalid params error is expected when nil withdrawals is used on a new payload in engine_newPayloadV2 and the payload is post-Shanghai.

Same error is also expected when non-nil withdrawals is used and the payload is pre-Shanghai.

https://github.com/ethereum/execution-apis/blob/main/src/engine/shanghai.md#request

Actual behavior

Geth is currently returning:

{"jsonrpc":"2.0","id":6,"result":{"status":"INVALID","latestValidHash":"0x8ad17628abbc44bfff20eb762125836fa1e46b414b2f452842b9a8410fffc309","validationError":"invalid withdrawalsHash: have 56e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421, expected nil"}}

and

{"jsonrpc":"2.0","id":22,"result":{"status":"INVALID","latestValidHash":"0x32d41f9fb7401b6fe23449c3bcdb9e57ab877f8fd3e9f5a9a9107659bd393fed","validationError":"missing withdrawalsHash"}}

Steps to reproduce the behaviour

Using ethereum/hive/pull/700, and running:

./hive --client go-ethereum --sim ethereum/engine --sim.limit "engine-withdrawals/Withdrawals Fork on Block 3"

will yield both errors at some point.

I think this is the last error found in hive for the withdrawals test suite :)

@MariusVanDerWijden MariusVanDerWijden self-assigned this Feb 3, 2023
@MariusVanDerWijden
Copy link
Member

fixed by #26691

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants