Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Error Number on Invalid Withdrawals Value for NewPayloadV2, ForkchoiceUpdatedV2 #26584

Closed
marioevz opened this issue Feb 1, 2023 · 0 comments · Fixed by #26591
Closed
Assignees
Labels

Comments

@marioevz
Copy link
Member

marioevz commented Feb 1, 2023

System information

Geth version: Geth/v1.11.0-unstable-5c8cc10d-20230201/linux-amd64/go1.19.5
CL client & version: Hive
OS & Version: Linux
Commit hash : 5c8cc10

Expected behaviour

Pre-Shanghai payloads with withdrawals or Post-Shanghai payloads with null-withdrawals in engine_newPayloadV2 must fail with error -32602.

Actual behaviour

Different error code:

{"jsonrpc":"2.0","id":1,"error":{"code":-38003,"message":"Invalid payload attributes","data":{"err":"withdrawals before shanghai"}}}

Same issue for engine_forkchoiceUpdatedV2 on the withdrawals field in payload attributes.

It's a very minor issue but hive tests are failing because of this.

Steps to reproduce the behaviour

./hive --client go-ethereum --sim ethereum/engine --sim.limit "engine-withdrawals/Withdrawals Fork on Block 3" --docker.nocache go-ethereum
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants