Skip to content

rpc: return chainId for legacy txs using EIP-155 signature + don't accept chainid in TransactionArgs #25141

@lightclient

Description

@lightclient

This issue came up in a discussion here: ethereum/execution-apis#239

I think the correct approach is to set chainId for legacy txs that take advantage of EIP-155. If we want to take it a step farther, we could say that chainId = 0 refers to a tx valid on any chain. This is essentially what the tx.ChainId() method does.

--

Additionally, accepting chainId in TransactionArgs seems superfluous. If chainId doesn't match with the client it should probably be an error anyways. Seems simpler to just remove it altogether.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions