Build fails at eth-go/ethdb/database.go:55

[sajal]

root@b7e73b91c780:/# go version
go version go1.2 linux/amd64
root@b7e73b91c780:/# go get -u github.com/ethereum/go-ethereum
# github.com/ethereum/eth-go/ethdb
go/src/github.com/ethereum/eth-go/ethdb/database.go:55: not enough arguments in call to db.db.NewIterator
root@b7e73b91c780:/#

[cayblood]

+1

[james-c]

This is due to this update - syndtr/goleveldb@26ca0eb to the goleveldb library being used.

It requires a fix in eth-go/ethdb/database.go

[sajal]

Go really needs some kind of dependency versioning...

[obscuren]

@sajal I agree to some degree. Though I don't think you should just remove or change any API without any notice. At least the developer of the leveldb should have given a deprecation warning of the sorts.

I'll get it fixed with the PoC3 release scheduled for today.

[sajal]

@obscuren : +1
New features should have new names, and old function should remain in place even if as a wrapper to the new one...

[james-c]

I issued a pull request to eth-go that fixes this, but it's extremely trivial.
Regarding other projects, I think it should be fundamental to a system that breaking API changes shouldn't be automatically pulled in to new builds when a downstream project changes - some kind of versioning should be in place.