internal/ethapi: fix chain ID check to return all non-zero IDs (#25244)

lightclient · web-flow · commit ae8ce7202244 · 2022-07-07T21:50:28.000+02:00
diff --git a/internal/ethapi/api.go b/internal/ethapi/api.go
@@ -1290,7 +1290,7 @@ func newRPCTransaction(tx *types.Transaction, blockHash common.Hash, blockNumber
 	switch tx.Type() {
 	case types.LegacyTxType:
 		// if a legacy transaction has an EIP-155 chain id, include it explicitly
-		if id := tx.ChainId(); id.Sign() == 0 {
+		if id := tx.ChainId(); id.Sign() != 0 {
 			result.ChainID = (*hexutil.Big)(id)
 		}
 	case types.AccessListTxType:

Original file line number	Diff line number	Diff line change
`@@ -1290,7 +1290,7 @@ func newRPCTransaction(tx *types.Transaction, blockHash common.Hash, blockNumber`
`1290`	`1290`	`switch tx.Type() {`
`1291`	`1291`	`case types.LegacyTxType:`
`1292`	`1292`	`// if a legacy transaction has an EIP-155 chain id, include it explicitly`
`1293`		`- if id := tx.ChainId(); id.Sign() == 0 {`
	`1293`	`+ if id := tx.ChainId(); id.Sign() != 0 {`
`1294`	`1294`	`result.ChainID = (*hexutil.Big)(id)`
`1295`	`1295`	`}`
`1296`	`1296`	`case types.AccessListTxType:`