Skip to content

Commit 592bf6a

Browse files
janosnonsense
authored andcommitted
swarm: fix flaky delivery tests (#18971)
1 parent c5c9cef commit 592bf6a

File tree

2 files changed

+1
-8
lines changed

2 files changed

+1
-8
lines changed

swarm/network/stream/delivery.go

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -259,13 +259,6 @@ func (d *Delivery) RequestFromPeers(ctx context.Context, req *network.Request) (
259259
if sp == nil {
260260
return true
261261
}
262-
// nodes that do not provide stream protocol
263-
// should not be requested, e.g. bootnodes
264-
if !p.HasCap("stream") {
265-
// TODO: if we have no errors, delete this if
266-
log.Error("Delivery.RequestFromPeers: peer doesn't have stream cap. we should have returned at sp == nil")
267-
return true
268-
}
269262
spID = &id
270263
return false
271264
})

swarm/network/stream/delivery_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -285,7 +285,7 @@ func TestRequestFromPeers(t *testing.T) {
285285
addr := network.RandomAddr()
286286
to := network.NewKademlia(addr.OAddr, network.NewKadParams())
287287
delivery := NewDelivery(to, nil)
288-
protocolsPeer := protocols.NewPeer(p2p.NewPeer(dummyPeerID, "dummy", []p2p.Cap{{Name: "stream"}}), nil, nil)
288+
protocolsPeer := protocols.NewPeer(p2p.NewPeer(dummyPeerID, "dummy", nil), nil, nil)
289289
peer := network.NewPeer(&network.BzzPeer{
290290
BzzAddr: network.RandomAddr(),
291291
LightNode: false,

0 commit comments

Comments
 (0)