eth/catalyst: fail on duplicate request types (#31071)

s1na · web-flow · commit 33756802f60f · 2025-01-23T20:38:09.000+01:00
Refer to: ethereum/execution-apis#623
diff --git a/eth/catalyst/api.go b/eth/catalyst/api.go
@@ -1303,7 +1303,8 @@ func validateRequests(requests [][]byte) error {
 			return fmt.Errorf("empty request: %v", req)
 		}
 		// Check that requests are ordered by their type.
-		if req[0] < last {
+		// Each type must appear only once.
+		if req[0] <= last {
 			return fmt.Errorf("invalid request order: %v", req)
 		}
 		last = req[0]

Original file line number	Diff line number	Diff line change
`@@ -1303,7 +1303,8 @@ func validateRequests(requests [][]byte) error {`
`1303`	`1303`	`return fmt.Errorf("empty request: %v", req)`
`1304`	`1304`	`}`
`1305`	`1305`	`// Check that requests are ordered by their type.`
`1306`		`- if req[0] < last {`
	`1306`	`+ // Each type must appear only once.`
	`1307`	`+ if req[0] <= last {`
`1307`	`1308`	`return fmt.Errorf("invalid request order: %v", req)`
`1308`	`1309`	`}`
`1309`	`1310`	`last = req[0]`