Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(tests): EOF - EIP-7620: EOFCREATE and RETURNDATA tests #532

Merged
merged 10 commits into from
May 29, 2024

Conversation

shemnon
Copy link
Collaborator

@shemnon shemnon commented Apr 28, 2024

Tests covering EOFCREATE and RETURNDATA, ported from evmone

Signed-off-by: Danno Ferrin danno@numisight.com

@shemnon shemnon marked this pull request as draft April 28, 2024 05:17
@shemnon shemnon force-pushed the eof/create branch 2 times, most recently from b4beca6 to ae09516 Compare April 29, 2024 23:51
@shemnon shemnon marked this pull request as ready for review April 30, 2024 01:05
Tests covering EOFCREATE and RETURNDATA, ported from evmone

Signed-off-by: Danno Ferrin <danno@numisight.com>
Signed-off-by: Danno Ferrin <danno@numisight.com>
add canary value

Signed-off-by: Danno Ferrin <danno@numisight.com>
@pdobacz
Copy link
Collaborator

pdobacz commented May 22, 2024

Hello, it appears I would like to add a test building on top of the additions in this PR. How can I help to get this merged?

shemnon and others added 5 commits May 22, 2024 13:50
Change all magic numbers for storage into variables.

Signed-off-by: Danno Ferrin <danno@numisight.com>
Signed-off-by: Danno Ferrin <danno@numisight.com>
@marioevz
Copy link
Member

@shemnon opened a PR to your branch shemnon#3. It only has some minor changes and I think the tests look pretty good!

@marioevz marioevz changed the title EOFCREATE and RETURNDATA tests new(tests): EOF - EIP-7620: EOFCREATE and RETURNDATA tests May 29, 2024
@marioevz marioevz merged commit a4b68e8 into ethereum:main May 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants