Initial Beacon Block Root Tests EIP-4788 #223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spencer-tb
force-pushed
the
tests-eip4788
branch
from
87ce9e3 to
fb787ac
Compare
marioevz
reviewed
Jul 25, 2023
Member
marioevz
left a comment
marioevz
left a comment
There was a problem hiding this comment.
Some comments! It looks pretty good so far :)
tests/cancun/eip4788_beacon_root/test_beacon_root_precompile.py
Outdated
Show resolved
Hide resolved
spencer-tb
force-pushed
the
tests-eip4788
branch
4 times, most recently
from
cd31f5b to
2926ec4
Compare
marioevz
reviewed
Jul 28, 2023
Member
marioevz
left a comment
marioevz
left a comment
There was a problem hiding this comment.
Some more comments, looks great so far!
spencer-tb
changed the title
spencer-tb
force-pushed
the
tests-eip4788
branch
from
8e6b949 to
549f154
Compare
Co-authored-by: Mario Vega <marioevz@gmail.com>
Collaborator
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Initial tests for EIP-4788:
https://eips.ethereum.org/EIPS/eip-4788
Issue: #150
Remaining tests -> moved to #236
🧪 Test Cases
test_beacon_root_precompile_calls: call the pre-compile across various contexts (CALL,DELEGATECALL, etc) using valid and invalid call gas, checks for the correct pc and call return values.test_beacon_root_precompile_timestamps: call the pre-compile using valid/invalid timestamps, checks for the correct pc return value.test_beacon_root_equal_to_timestamp: call the pre-compile where timestamp = beacon block root.test_beacon_root_tx_timestamp_collisions: call the pre-compile multiple times in one tx, using different timestamps that have equal timestamp indexes.✅ Remaining Tasks
Add remaining tests-> moved to Remaining Beacon Block Root Tests EIP-4788 #236types.py, and add payload field for hive tests.