Skip to content

Conversation

raxhvl
Copy link
Member

@raxhvl raxhvl commented Sep 26, 2025

🗒️ Description

  • test_bal_7702_delegation_create - Ensure BAL captures creation of EOA delegation
  • test_bal_7702_delegation_update - Ensure BAL captures update of existing EOA delegation
  • test_bal_7702_delegation_clear - Ensure BAL captures clearing of EOA delegation
  • test_bal_7702_delegated_storage_access - Ensure BAL captures storage operations when calling a delegated EIP-7702 account.
  • test_bal_7702_invalid_nonce_authorization - Ensure BAL handles failed authorization due to wrong nonce.
  • test_bal_7702_invalid_chain_id_authorization - Ensure BAL handles failed authorization due to chain id.

✅ Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlint
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

@raxhvl raxhvl self-assigned this Sep 26, 2025
@raxhvl raxhvl added the scope:tests Scope: Changes EL client test cases in `./tests` label Sep 26, 2025
@fselmo
Copy link
Collaborator

fselmo commented Sep 30, 2025

We should rebase this and fix the lint errors. Do you think these tests deserve their own file as well? I don't mind it for 7702 but I'd rather take a step back and see how we want to organize them so there aren't only a few per file and many files.

@raxhvl raxhvl force-pushed the fix/eip-7928/eip-7702 branch from 13eaf46 to 184d5d7 Compare October 2, 2025 08:31
@raxhvl
Copy link
Member Author

raxhvl commented Oct 2, 2025

I feel 7702 test cases would need a separate file. Say we create a new file if we hit > 500 LOC? Any other method for organization in mind? I lean towards smaller files. Would you know if is there a perf hit for splitting files?

Another idea: #2167 (comment)

I rebased on main.

raxhvl and others added 2 commits October 6, 2025 09:29
🧹 chore: Update test case

✨ feat(tests): test_bal_7702_invalid_chain_id_authorization

✨ feat(tests): test_bal_7702_invalid_nonce_authorization

✨ feat(tests): test_bal_7702_delegated_storage_access

✨ feat(tests): test_bal_7702_delegation_clear

✨ feat(tests): test_bal_7702_delegation_update

✨ feat(tests): test_bal_7702_delegation_create
@fselmo fselmo force-pushed the fix/eip-7928/eip-7702 branch from 907a64b to f88b604 Compare October 6, 2025 15:30
@fselmo
Copy link
Collaborator

fselmo commented Oct 7, 2025

@raxhvl I'm good with 7702 having its own file. At least for now. We should wait until this PR is reviewed by Toni and merged but can you make sure that this looks good on your end?

It looks good to me but please review the last two commits here as a sanity check. I added the test case for calling a delegated address from all call opcodes because I had a hunch this was also not working right still and I made some updates to the specs side (what we should wait for to merge there). All tests now pass with those changes for me.

I am holding off on approving only because I want to prevent merging until the specs are updated and merged so we can point the resolver to the updated hash there and get the correct logic for these 7702 tests to actually fill.

@fselmo fselmo force-pushed the fix/eip-7928/eip-7702 branch from c1599e2 to a73376d Compare October 7, 2025 21:24
@fselmo
Copy link
Collaborator

fselmo commented Oct 7, 2025

I think we get this one settled and then we can rebase #2116, remove duplicates, do one last pass there and hopefully get that merged pretty quickly after this.

@ethereum ethereum deleted a comment from raxhvl Oct 8, 2025
Copy link
Collaborator

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Pointed this to the updated specs and all tests are filling as they should. Nice work 👌🏼

@fselmo fselmo merged commit 39e8316 into main Oct 8, 2025
16 checks passed
@fselmo fselmo deleted the fix/eip-7928/eip-7702 branch October 8, 2025 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope:tests Scope: Changes EL client test cases in `./tests`

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants