Skip to content

add blockTimestamp to Logs #639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wighawag
Copy link

@wighawag
Copy link
Author

wighawag commented Apr 5, 2025

how do we proceed from there to move that forward ?

the ethereum magician thread show enthusiasm about the changes and it should be relatively trivial to implement it across all clients. it is also already implemented in reth

@mattstam
Copy link

@lightclient @mkalinin What are the next steps to moving this forward?

@jochem-brouwer
Copy link
Member

Hey, I'm not sure, but we have recently started setting up RPC standardization calls and I think this is the place where we want to put/create this process. I think currently there is not a well defined answer on "how to move forward" here 😅. But this is the idea of the call. Today (monday 12 May) is this call, see: ethereum/pm#1529

I will try to join this call and also bring up this PR. I would suggest anyone who provides RPC endpoints to join these calls, because this is the kind of call to bring up changes to the RPC API.

Note: the JSON-RPC API is currently NOT standardized, so this is also part of the call. This repository is kind-of-the-standard, but some clients do not completely support the spec here. We also currently lack tests (there are some, but they definitely do not cover all). The idea for the call is to also collect feedback from RPC providers/users on what is missing.

I know this is kind of a late notice but I would suggest to join it today if possible (15 UTC). For the zoom URL to join, you'd likely have to go to the #json-rpc-api channel of Eth R&D on discord: https://discord.gg/M6wtqNzqjj

CC @wighawag @mattstam

@jochem-brouwer
Copy link
Member

I have just asked, the RPC calls are indeed to bring this up 😄 👍 The next call should be in two weeks. If I don't forget, I'll re-link it here 😄

@wighawag
Copy link
Author

Thanks @jochem-brouwer!
I was planning to go in the call but in the end was busy with something else. glad to know there will be a call for it in 2 weeks. Hopefuly we can move this forward

@jochem-brouwer
Copy link
Member

Next call is scheduled here: ethereum/pm#1544

Hope to see you there 😄 👍 Please note that we are still working on the process itself how to ship these kind of changes, but it would be nice to have an actual proposal there 😄 👍

@miguelmtzinf
Copy link

miguelmtzinf commented May 19, 2025

At Aave Labs, we’ve been running into this issue for quite some time—needing to make extra RPC calls just to get the block timestamp for events we’re handling. It’s pretty inefficient, and because of that, we’ve had to explore workarounds like adding extra data to events or including the timestamp directly. We’d really love to see this initiative move forward so node operators include timestamps in the RPC response.

It would make things much more efficient for indexing services and be a real game-changer overall! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants