Add schemas for withdrawals from EIP-4895 #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralexstokes
commented
Dec 12, 2022
src/schemas/block.yaml
Outdated
Comment on lines
90
to
95
| withdrawals: | ||
| anyOf: | ||
| - title: Full withdrawals | ||
| type: array | ||
| items: | ||
| $ref: '#/components/schemas/Withdrawal' |
There was a problem hiding this comment.
to confirm, I expect this to encode the following behavior:
pre-fork, the field is absent or null
post-fork, the field is an array full of withdrawals or the empty array
lightclient
reviewed
Dec 12, 2022
There was a problem hiding this comment.
Generally looks good, but this will need tests added. For info on generating tests, see this document.
ralexstokes
force-pushed
the
4895-updates
branch
from
6580a66
to
5227dbb
Compare
siladu
reviewed
Dec 20, 2022
siladu
added a commit
to siladu/besu
that referenced
this pull request
Dec 20, 2022
…kByNumber As per ethereum/execution-apis#334 Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
|
We should try to get this merged before next release. |
ralexstokes
force-pushed
the
4895-updates
branch
from
5227dbb
to
304e786
Compare
lightclient
force-pushed
the
4895-updates
branch
from
304e786
to
3bac993
Compare
lightclient
force-pushed
the
4895-updates
branch
from
3bac993
to
e4b9a36
Compare
|
I extended rpctestgen to support withdrawals and generated some tests. |
mcdee
suggested changes
Jan 11, 2023
siladu
reviewed
Jan 11, 2023
lightclient
reviewed
Jan 27, 2023
yes, don't complicate the API w/o good reason |
lightclient
force-pushed
the
4895-updates
branch
from
b12d05f
to
692b5e6
Compare
lightclient
approved these changes
Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
^