-
Notifications
You must be signed in to change notification settings - Fork 477
Description
EIP-1898 is in Final status. It adds the option to use a block hash in several state access methods, where previously a block number was the only option.
The spec mostly has this covered with the BlockNumberOrTagOrHash type:
execution-apis/src/schemas/block.yaml
Line 130 in 3547418
| BlockNumberOrTagOrHash: |
However, the spec is missing the case where the input is a JSON object like {"blockHash": "0x...", "requireCanonical": true} is given. We need to add this to the spec and also create tests that verify this with all the methods which are affected.
Unfortunately, we do not have any sidechains in the test chain, i.e. we can't query for non-canonical blocks. Either this part will have to be left untested or we need to updated the test methodology to import a sidechain before importing the canonical one.