Implement BLOBBASEFEE instruction from EIP-7516
#708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #708 +/- ##
=======================================
Coverage 97.69% 97.70%
=======================================
Files 101 102 +1
Lines 9381 9404 +23
=======================================
+ Hits 9165 9188 +23
Misses 216 216
Flags with carried forward coverage won't be shown. Click here to find out more.
|
axic
reviewed
Sep 25, 2023
| @@ -510,6 +510,11 @@ inline void blobhash(StackTop stack, ExecutionState& state) noexcept | |||
| 0; | |||
| } | |||
|
|
|||
| inline void blobbasefee(StackTop stack, ExecutionState& state) noexcept | |||
There was a problem hiding this comment.
I think there are some discussions renaming this. Should we wait for that or merge?
There was a problem hiding this comment.
This is likely the name we will end up with.
yperbasis
approved these changes
Sep 28, 2023
pdobacz
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
BLOBBASEFEEinstruction from EIP-7516: "BLOBBASEFEE opcode".