Blockchain tests support: Clear accounts and their storage warm flag after each tx #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #679 +/- ##
=======================================
Coverage 97.48% 97.48%
=======================================
Files 85 85
Lines 8177 8182 +5
=======================================
+ Hits 7971 7976 +5
Misses 206 206
Flags with carried forward coverage won't be shown. Click here to find out more.
|
chfast
reviewed
Aug 10, 2023
test/t8n/t8n.cpp
Outdated
| @@ -155,6 +155,16 @@ int main(int argc, const char* argv[]) | |||
| transactions.emplace_back(std::move(tx)); | |||
| receipts.emplace_back(std::move(receipt)); | |||
| } | |||
|
|
|||
| for (auto& acc : state.get_accounts()) | |||
There was a problem hiding this comment.
I think this should be done as a part of state::transition().
There was a problem hiding this comment.
Done. I did not separate it to a function but can do it if it makes sense. For me it doesn't yet.
rodiazet
force-pushed
the
clear-accounts-flags-t8n
branch
from
ecdfa93
to
b81712e
Compare
chfast
changed the title
chfast
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.