Implement EIP-1153: Transient storage #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chfast
force-pushed
the
transient_storage
branch
2 times, most recently
from
fe7c324
to
8ae3166
Compare
rodiazet
reviewed
Aug 21, 2023
rodiazet
reviewed
Aug 21, 2023
chfast
force-pushed
the
transient_storage
branch
from
8ae3166
to
c497dfd
Compare
gumb0
reviewed
Aug 22, 2023
gumb0
reviewed
Aug 22, 2023
| @@ -119,6 +119,8 @@ constexpr bool instruction_only_in_evmone(evmc_revision rev, Opcode op) noexcept | |||
| case OP_DATALOADN: | |||
| case OP_DATASIZE: | |||
| case OP_DATACOPY: | |||
| case OP_TLOAD: | |||
There was a problem hiding this comment.
You could add them to EVMC already
There was a problem hiding this comment.
I stopped adding these to EVMC (e.g. MCOPY is missing). This seems double work with little benefits. Also EVMC instruction information is not directly usable by evmone because not constexpr.
What do you think about removing instructions from EVMC? This is a bit of work, but can be done.
There was a problem hiding this comment.
Probably fine, if nobody uses them.
gumb0
reviewed
Aug 22, 2023
chfast
force-pushed
the
transient_storage
branch
2 times, most recently
from
1cbbeff
to
c7efc99
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #669 +/- ##
==========================================
+ Coverage 97.54% 97.56% +0.01%
==========================================
Files 91 92 +1
Lines 8473 8535 +62
==========================================
+ Hits 8265 8327 +62
Misses 208 208
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Looks good to me, needs rebase. |
gumb0
force-pushed
the
transient_storage
branch
from
c7efc99
to
c61f94a
Compare
gumb0
approved these changes
Sep 1, 2023
chfast
force-pushed
the
transient_storage
branch
2 times, most recently
from
d5c39ba
to
13e210b
Compare
chfast
force-pushed
the
transient_storage
branch
2 times, most recently
from
8410872
to
e391fa6
Compare
chfast
force-pushed
the
transient_storage
branch
from
e391fa6
to
5da3bef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eips.ethereum.org/EIPS/eip-1153