Reject DELEGATECALL EOF → legacy

[axic]

The code targeted by DELEGATECALL from an EOF must also be an EOF.
This restriction has been added to EIP-3540 in
ethereum/EIPs#7131.

[axic]

@chfast @gumb0 any feedback on the direction (before I start adding tests / more code)?

[chfast]

Looks good in general.

I think we should do an experiment to pass "EOF mode" flag instead of checking code prefix in many places. But this can be done after this PR to asses full impact of the re-design.

[codecov]

Codecov Report

Merging #588 (3fad1cb) into master (1f8823e) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

❗ Current head 3fad1cb differs from pull request most recent head 7fe279e. Consider uploading reports for the commit 7fe279e to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #588      +/-   ##
==========================================
- Coverage   97.39%   97.34%   -0.05%     
==========================================
  Files          80       81       +1     
  Lines        7973     7770     -203     
==========================================
- Hits         7765     7564     -201     
+ Misses        208      206       -2     

Flag	Coverage Δ
blockchaintests	64.04% <25.00%> (+0.97%)	⬆️
statetests	74.60% <100.00%> (+0.59%)	⬆️
unittests	94.85% <100.00%> (-0.11%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
lib/evmone/instructions_calls.cpp	100.00% <100.00%> (ø)
test/unittests/evm_eof_calls_test.cpp	100.00% <100.00%> (ø)

... and 16 files with indirect coverage changes