Add project version printing for t8n executable #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axic
reviewed
Feb 8, 2023
test/t8n/t8n.cpp
Outdated
| @@ -47,7 +47,7 @@ int main(int argc, const char* argv[]) | |||
|
|
|||
| if (arg == "-v") | |||
| { | |||
| std::cout << "evmone dev\n"; // FIXME: Return proper version. | |||
| std::cout << "evmone " << PROJECT_VERSION << std::endl; | |||
There was a problem hiding this comment.
Suggested change
| std::cout << "evmone " << PROJECT_VERSION << std::endl; | |
| std::cout << "evmone-t8n " << PROJECT_VERSION << std::endl; |
Why not?
There was a problem hiding this comment.
Depends what you want to see in the generated tests.
There was a problem hiding this comment.
I think -t8n is ok. We will probably will have also project versions for other executables so it's good to distinct them
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #555 +/- ##
==========================================
+ Coverage 97.00% 97.01% +0.01%
==========================================
Files 66 64 -2
Lines 6134 6122 -12
==========================================
- Hits 5950 5939 -11
+ Misses 184 183 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
rodiazet
force-pushed
the
t8n-project-version
branch
from
94c60e1
to
d78e87d
Compare
axic
approved these changes
Feb 8, 2023
chfast
requested changes
Feb 8, 2023
test/t8n/t8n.cpp
Outdated
| @@ -47,7 +47,7 @@ int main(int argc, const char* argv[]) | |||
|
|
|||
| if (arg == "-v") | |||
| { | |||
| std::cout << "evmone dev\n"; // FIXME: Return proper version. | |||
| std::cout << "evmone-t8n " << PROJECT_VERSION << std::endl; | |||
There was a problem hiding this comment.
Suggested change
| std::cout << "evmone-t8n " << PROJECT_VERSION << std::endl; | |
| std::cout << "evmone-t8n " PROJECT_VERSION "\n"; |
There was a problem hiding this comment.
The string will be concatenated by the compiler and std::cout called only once.
rodiazet
force-pushed
the
t8n-project-version
branch
from
d78e87d
to
7b33ad7
Compare
chfast
approved these changes
Feb 8, 2023
rodiazet
force-pushed
the
t8n-project-version
branch
from
7b33ad7
to
c6a1624
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.