Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get instruction names from instr::traits[] #534

Merged
merged 3 commits into from
Nov 30, 2022
Merged

Conversation

chfast
Copy link
Member

@chfast chfast commented Nov 29, 2022

This removes the dependency on evmc::instructions for getting instruction names for tracing and testing.

@chfast chfast requested a review from rodiazet November 29, 2022 22:51
@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Merging #534 (72276a4) into master (12009ab) will decrease coverage by 0.00%.
The diff coverage is 94.73%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #534      +/-   ##
==========================================
- Coverage   98.03%   98.02%   -0.01%     
==========================================
  Files          59       59              
  Lines        5703     5682      -21     
==========================================
- Hits         5591     5570      -21     
  Misses        112      112              
Flag Coverage Δ
blockchaintests 78.38% <0.00%> (+0.40%) ⬆️
statetests 72.91% <0.00%> (+0.23%) ⬆️
unittests 91.71% <94.73%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/unittests/instructions_test.cpp 85.29% <0.00%> (ø)
lib/evmone/tracing.cpp 100.00% <100.00%> (ø)
test/unittests/bytecode_test.cpp 100.00% <100.00%> (ø)
test/unittests/evm_state_test.cpp 100.00% <100.00%> (ø)
test/unittests/evm_test.cpp 100.00% <100.00%> (ø)
test/unittests/tracing_test.cpp 100.00% <100.00%> (ø)
test/utils/bytecode.hpp 96.33% <100.00%> (-0.12%) ⬇️

@chfast chfast merged commit 698e019 into master Nov 30, 2022
@chfast chfast deleted the instruction_names branch November 30, 2022 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants