Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DS implementation - SideNav #13230

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from
Draft

DS implementation - SideNav #13230

wants to merge 2 commits into from

Conversation

pettinarip
Copy link
Member

This PR is a follow up to #13063. See this comment for more context on why we closed that PR.

Description

Adds the new SideNav component that matches the DS styles.

Related issue

@netlify Netlify
Copy link

netlify bot commented Jun 24, 2024 •
edited
Loading

✅ Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 2a7af39
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/667990c6bafeaf00086d6968
😎 Deploy Preview https://deploy-preview-13230--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 7 paths audited
Performance: 45 (🔴 down 2 from production)
Accessibility: 92 (no change from production)
Best Practices: 83 (🔴 down 9 from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the tooling 🔧 Changes related to tooling of the project label Jun 24, 2024
@pettinarip pettinarip mentioned this pull request Jun 24, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Jul 25, 2024
@minimalsm
Copy link
Contributor

@pettinarip any reason this is still in draft?

@github-actions github-actions bot removed the Status: Stale This issue is stale because it has been open 30 days with no activity. label Aug 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wackerow wackerow Awaiting requested review from wackerow wackerow will be requested when the pull request is marked ready for review wackerow is a code owner

@corwintines corwintines Awaiting requested review from corwintines corwintines will be requested when the pull request is marked ready for review corwintines is a code owner

@minimalsm minimalsm Awaiting requested review from minimalsm minimalsm will be requested when the pull request is marked ready for review minimalsm is a code owner

At least 0 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
Status: Stale This issue is stale because it has been open 30 days with no activity. tooling 🔧 Changes related to tooling of the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SideNav
2 participants
@pettinarip @minimalsm