Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable record types #167

Merged
merged 2 commits into from
Feb 23, 2022
Merged

Enable record types #167

merged 2 commits into from
Feb 23, 2022

Conversation

nhsz
Copy link
Member

@nhsz nhsz commented Feb 22, 2022

This PR adds the corresponding RecordTypeId's to the SF's integrations

@netlify
Copy link

netlify bot commented Feb 22, 2022

✔️ Deploy Preview for thirsty-meitner-cae269 ready!

🔨 Explore the source changes: 798401a

🔍 Inspect the deploy log: https://app.netlify.com/sites/thirsty-meitner-cae269/deploys/62155ff675c7d30007bf84ce

😎 Browse the preview: https://deploy-preview-167--thirsty-meitner-cae269.netlify.app

@nhsz nhsz requested review from pettinarip and removed request for pettinarip, corwintines and wackerow February 22, 2022 22:13
Copy link
Member

@samajammin samajammin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Any reason they need to be ENV variables?

@nhsz
Copy link
Member Author

nhsz commented Feb 23, 2022

LGTM. Any reason they need to be ENV variables?

No major reason, in my view it seems more 'clean' to not display hardcoded config values (like the RecordTypeId) directly on the code, I think they add noise, what do you think?

@nhsz nhsz merged commit 827e63d into esp-redesign Feb 23, 2022
@nhsz nhsz deleted the enable-record-types branch February 23, 2022 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants