Remove verify_cell_kzg_proof (non-batch)
#3830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we make it a note in an appendix? I think it's useful for testing, fuzzing or while making step-by-step progress in an implementation. |
Hmm, have we done this before in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The specs and clients are only expected to use
verify_cell_kzg_proof_batch, so we could removeverify_cell_kzg_proof. This would simplify things quite a bit. In ckzg, we could delete ~200 lines of C code and a bunch of code in the bindings. It's still possible to verify a single cell with the batch function and the performance is essentially the same.