Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move 4788 to deneb #3421

Merged
merged 4 commits into from
Jun 22, 2023
Merged

move 4788 to deneb #3421

merged 4 commits into from
Jun 22, 2023

Conversation

ralexstokes
Copy link
Member

@ralexstokes ralexstokes commented Jun 12, 2023 •
edited
Loading

migrates EIP-4788 spec from an experimental feature to part of Deneb

@ralexstokes ralexstokes mentioned this pull request Jun 12, 2023
Open
@ralexstokes ralexstokes force-pushed the 4788-in-deneb branch 16 times, most recently from 02a40f3 to daa581b Compare June 13, 2023 03:13
hwwhww
hwwhww reviewed Jun 13, 2023
View reviewed changes
Copy link
Contributor

@hwwhww hwwhww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Need to initialize the state.latest_execution_payload_header.parent_beacon_block_root value in specs/deneb/fork.md::upgrade_to_deneb helper.

The rest changes look good to me. 👍

specs/deneb/beacon-chain.md Outdated Show resolved Hide resolved
specs/deneb/fork-choice.md Outdated Show resolved Hide resolved
tests/core/pyspec/eth2spec/test/deneb/block_processing/test_process_execution_payload.py Outdated Show resolved Hide resolved
@hwwhww hwwhww added the Deneb was called: eip-4844 label Jun 13, 2023
This was referenced Jun 13, 2023
Open
Closed
hwwhww
hwwhww approved these changes Jun 14, 2023
View reviewed changes
Copy link
Contributor

@hwwhww hwwhww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

djrtwo
djrtwo reviewed Jun 14, 2023
View reviewed changes
Copy link
Contributor

@djrtwo djrtwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think we can/should get rid of the helper noted below

specs/deneb/beacon-chain.md Outdated Show resolved Hide resolved
specs/deneb/beacon-chain.md Outdated Show resolved Hide resolved
specs/deneb/validator.md Outdated Show resolved Hide resolved
@tbenr tbenr mentioned this pull request Jun 15, 2023
Closed
@ralexstokes ralexstokes force-pushed the 4788-in-deneb branch 11 times, most recently from 051ae2f to 3707ef9 Compare June 21, 2023 22:01
djrtwo
djrtwo approved these changes Jun 22, 2023
View reviewed changes
specs/deneb/beacon-chain.md Outdated Show resolved Hide resolved
specs/deneb/beacon-chain.md Show resolved Hide resolved
specs/deneb/beacon-chain.md Show resolved Hide resolved
specs/deneb/beacon-chain.md Outdated Show resolved Hide resolved
specs/deneb/beacon-chain.md Outdated Show resolved Hide resolved
specs/deneb/fork-choice.md Outdated Show resolved Hide resolved
@djrtwo djrtwo merged commit c475b13 into ethereum:dev Jun 22, 2023
@ralexstokes ralexstokes deleted the 4788-in-deneb branch June 22, 2023 19:33
@ralexstokes ralexstokes mentioned this pull request Jun 22, 2023
Merged
3 tasks
@g11tech g11tech mentioned this pull request Jun 25, 2023
Merged
@terencechain terencechain mentioned this pull request Jun 27, 2023
Merged
@realbigsean realbigsean mentioned this pull request Jun 29, 2023
Closed
tersec added a commit to status-im/nimbus-eth2 that referenced this pull request Jun 29, 2023
@tersec
ethereum/consensus-specs#3421 ethereum/execution-apis#420
d699ff3
@tersec tersec mentioned this pull request Jun 29, 2023
Merged
tersec added a commit to status-im/nimbus-eth2 that referenced this pull request Jun 29, 2023
@tersec
ethereum/consensus-specs#3421 ethereum/execution-apis#420
5b5331c
tersec added a commit to status-im/nimbus-eth2 that referenced this pull request Jun 30, 2023
@tersec
ethereum/consensus-specs#3421 ethereum/execution-apis#420 (#5147)
b4c4f09
@henridf henridf mentioned this pull request Jul 12, 2023
Closed
6 tasks
@djrtwo djrtwo mentioned this pull request Jul 17, 2023
Closed
@jimmygchen jimmygchen mentioned this pull request Jul 19, 2023
Closed
@hwwhww hwwhww mentioned this pull request Aug 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkalinin mkalinin mkalinin left review comments

@etan-status etan-status etan-status left review comments

@djrtwo djrtwo djrtwo approved these changes

@hwwhww hwwhww hwwhww approved these changes

@g11tech g11tech g11tech approved these changes

Assignees
No one assigned
Labels
Deneb was called: eip-4844
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ralexstokes @djrtwo @mkalinin @hwwhww @g11tech @etan-status