specially mark EIP4844 changes #3406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwwhww
changed the title
hwwhww
commented
Jun 7, 2023
| @@ -41,16 +41,15 @@ | |||
|
|
|||
| ## Introduction | |||
|
|
|||
| This upgrade adds blobs to the beacon chain as part of Deneb. This is an extension of the Capella upgrade. | |||
|
|
|||
| The blob transactions are packed into the execution payload by the EL/builder with their corresponding blobs being independently transmitted and are limited by `MAX_DATA_GAS_PER_BLOCK // DATA_GAS_PER_BLOB`. However the CL limit is independently defined by `MAX_BLOBS_PER_BLOCK`. | |||
There was a problem hiding this comment.
I moved this note to next to MAX_BLOBS_PER_BLOCK preset definition.
Comment on lines
+44
to
+45
| Deneb is a consensus-layer upgrade containing a number of features. Including: | ||
| * [EIP-4844](https://eips.ethereum.org/EIPS/eip-4844): Shard Blob Transactions scale data-availability of Ethereum in a simple, forwards-compatible manner. |
There was a problem hiding this comment.
other features will join this list later
djrtwo
reviewed
Jun 7, 2023
| @@ -336,7 +336,7 @@ def evaluate_polynomial_in_evaluation_form(polynomial: Polynomial, | |||
|
|
|||
| ### KZG | |||
|
|
|||
| KZG core functions. These are also defined in Deneb execution specs. | |||
| KZG core functions. These are also defined in Deneb execution specs for EIP-4844. | |||
There was a problem hiding this comment.
The top of this doc mentions "required for Deneb specification". I might be explicit up there that it is for 4844 (within Deneb)
specs/deneb/validator.md
Outdated
| @@ -98,6 +98,8 @@ All validator responsibilities remain unchanged other than those noted below. | |||
|
|
|||
| ##### Blob KZG commitments | |||
|
|
|||
| [New in Deneb:EIP4844] | |||
There was a problem hiding this comment.
Seems like we should add more annotations to this doc -- e.g. to "Constructing the SignedBlobSidecars" and the data structures added
ralexstokes
approved these changes
Jun 8, 2023
ppopth
approved these changes
Jun 9, 2023
djrtwo
approved these changes
Jun 9, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are planning to include additional features (#3182) in the Deneb fork. This PR modifies the previous "[New in Deneb]" comment to "[New in Deneb:EIP4844]", allowing us to differentiate the sources once we integrate these new features.
Usine the notation
EIP4844rather thanEIP-4844because it's the form we use for feature spec constant, and it's shorter.