Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

custody_bits_blocks in Attestation #1905

Open
ericsson49 opened this issue Jun 17, 2020 · 1 comment
Open

custody_bits_blocks in Attestation #1905

ericsson49 opened this issue Jun 17, 2020 · 1 comment
Labels
phase1

Comments

@ericsson49
Copy link
Contributor

ericsson49 commented Jun 17, 2020 •
edited
Loading

Attestation had custody_bits_blocks:

custody_bits_blocks: List[Bitlist[MAX_VALIDATORS_PER_COMMITTEE], MAX_SHARD_BLOCKS_PER_ATTESTATION]

It's used by is_valid_fraud_proof.
Looks like it was dropped during recent merge: it's missing here. But is present here.
@ericsson49
Copy link
Contributor Author

As @jrhea pointed out it's dropped by intention.
So, it looks like is_valid_fraud_proof has not been updated appropriately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
phase1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@JustinDrake @ericsson49 and others