Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fork choice maximum reversions #1520

Open
djrtwo opened this issue Dec 12, 2019 · 3 comments
Open

Fork choice maximum reversions #1520

djrtwo opened this issue Dec 12, 2019 · 3 comments

Comments

@djrtwo
Copy link
Contributor

djrtwo commented Dec 12, 2019

Pulled from the old ForkChoice checklist at #1053

Maximum reversions: Enshrine dynamic weak subjectivity reversion period into fork choice rule ("second finality mechanism").

@vbuterin @JustinDrake What are the thoughts and reasoning here? Should this still be integrated?

@djrtwo djrtwo mentioned this issue Dec 12, 2019
10 tasks
@JustinDrake
Copy link
Collaborator

My understanding is that, technically speaking, we do want to enshrine the weak subjectivity period in the fork choice rule, especially in the context of "surviving WW3". Having said that, from a pragmatic standpoint it may be best to sweep this detail under the rug until phase 1+. Indeed, hitting the weak subjectivity period without finality is an exceptional condition which is a) unlikely to happen, and b) would likely be handled with manual intervention. My inclination would be to formally update the fork choice in phase 1 so as to not distract the launch of phase 0. Tagging this issue as phase 1 for now :)

@djrtwo
Copy link
Contributor Author

djrtwo commented Dec 16, 2019

Agree with the push

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants
@JustinDrake @djrtwo @hwwhww and others