Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify universal verification function (das branch) #448

Closed
asn-d6 opened this issue Jun 27, 2024 · 1 comment
Closed

Simplify universal verification function (das branch) #448

asn-d6 opened this issue Jun 27, 2024 · 1 comment

Comments

@asn-d6
Copy link
Contributor

asn-d6 commented Jun 27, 2024

The "Compute sum of commitments" code can be simplified by just doing an MSM over all commitments and their weights. That is, without sieving which are used and which are not which IMO complicates the codebase. Anything that is not used would have zero weight and hence it would not contribute to the MSM.

This is what @b-wagn did in his PR (ethereum/consensus-specs#3812) and it's simpler.

After all, if I'm not mistaken, for PeerDAS we will always use all the commitments since we fetch the entire column, so we will not do any wasted bytes_to_kzg_commitment().

@asn-d6
Copy link
Contributor Author

asn-d6 commented Jun 27, 2024

Implemented by Justin in 47bb90d

@asn-d6 asn-d6 closed this as completed Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant