-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update EIP-7691: add update fraction specification #9060
Conversation
✅ All reviewers have approved. |
Thanks for opening this one. To add some context, as agreed on ACD, we may want to increase the update base fee fraction in 7691 in order to ensure the base fee scales appropriately. usually we would do something like "target_blob_gas / ln(1.125)" but since we're moving away from symmetric base fee scaling we might want to lower the update fraction relative to the target blob gas we currently use. I'm fine with the value as-is in this PR. |
Added rationale to EIP:
The alternative options we would have: Keep update fraction at today's value:
Keep update fraction proportional to target (i.e. double it):
I'd argue the mid-point value chosen in the PR is the simplest available compromise, but happy to change it if people disagree. DISCLAIMER: I haven't double checked any of these numbers yet, there could be a mistake somewhere. |
The commit f8da514 (as a parent of cc53043) contains errors. |
yes rationale looks good to me |
f8da514
to
280cf83
Compare
Co-authored-by: g11tech <develop@g11tech.io>
* full blobs: basefee increases by ~12.5% | ||
* no blobs: basefee decreases by ~11.1% | ||
|
||
The new target and max values from this EIP are at a 2:3 ratio, which breaks that symmetry.As a consequence, the basefee becomes significantly more responsive to empty blob sections (that are 6 blobs under target) than to full ones (that are 3 blobs over target). This is by design, as it takes two blocks with full blobs in a row to make up for a single block with no blobs. However, it creates the challenge of finding a good compromise base fee sensitivity level. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add space between "symmetry" and "As a consequence"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All Reviewers Have Approved; Performing Automatic Merge...
wip
todo: