Update EIP-7685: group requests into request-data #8924
Merged
+27
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c-update
|
✅ All reviewers have approved. |
eth-bot
changed the title
lightclient
force-pushed
the
7685-group-request-data
branch
from
e402996
to
2dfa06a
Compare
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
eth-bot
approved these changes
Oct 7, 2024
mkalinin
reviewed
Oct 8, 2024
| def compute_requests_hash(requests): | ||
| m = sha256() | ||
| for r in requests: | ||
| m.update(sha256(r)) |
There was a problem hiding this comment.
According to the PR’s description, there is a type byte hashed in front of every list. In this particular case not having a “domain” byte is fine because the order already does this implicitly. Just want to confirm this algo in the spec is the one that it was intended to be
There was a problem hiding this comment.
maybe not the clearest, but each r in requests is the prefixed data already
3 tasks
11 tasks
4 tasks
8 tasks
This was referenced Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully this encapsulates the discussion on discord and in #8916.
Essentially, we now refer to
request_dataas the opaque data output by the system contract instead of a request's individual fields and we modify therequest_hashcalculation to be the following: