Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EIP: Zero-Knowledge AI-Generated Content Token #7007

Merged
merged 11 commits into from
Jun 19, 2023

Conversation

xhyumiracle
Copy link
Contributor

No description provided.

@xhyumiracle xhyumiracle requested a review from eth-bot as a code owner May 10, 2023 10:57
@github-actions github-actions bot added c-new Creates a brand new proposal s-draft This EIP is a Draft t-erc labels May 10, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented May 10, 2023

✅ All reviewers have approved.

@eth-bot eth-bot added e-consensus Waiting on editor consensus e-review Waiting on editor to review labels May 10, 2023
@github-actions github-actions bot added the w-ci Waiting on CI to pass label May 10, 2023
@github-actions
Copy link

The commit 0b311f1 (as a parent of 228e334) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot removed the w-ci Waiting on CI to pass label May 10, 2023
@eth-bot eth-bot added a-review Waiting on author to review and removed e-review Waiting on editor to review labels May 11, 2023
ghost
ghost previously approved these changes May 12, 2023
socathie
socathie previously approved these changes May 25, 2023
@socathie
Copy link

@axic @Pandapip1 @SamWilsn @xinbenlv Sorry for tagging. We are just wondering if this issue has been mislabeled as a-review instead of e-review and whether this has delayed the review process? Thanks.

EIPS/eip-7007.md Outdated
eip: 7007
title: zkML AIGC-NFTs
description: An ERC-721 extension interface for zkML based AIGC-NFTs.
author: Cathie So (@socathie), Xiaohang Yu <xhyumiracle@hyperoracle.io>, Huaizhe Xu (@HuaizheXu), Kartin <kartin@hyperoracle.io>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll want to add your GitHub username as an author or else you won't be able to edit the proposal without getting approvals from the other authors.

EIPS/eip-7007.md Outdated Show resolved Hide resolved
EIPS/eip-7007.md Outdated

The zkML AIGC-NFTs standard includes the following interfaces:

ERC-7007: Defines a mint event and a mint function for minting AIGC-NFTs. It also includes a verify function to check the validity of a combination of prompt and proof using zkML techniques.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming the bot made you put a dash here? If you use backticks to indicate inline code, the bot won't complain:

Suggested change
ERC-7007: Defines a mint event and a mint function for minting AIGC-NFTs. It also includes a verify function to check the validity of a combination of prompt and proof using zkML techniques.
`IERC7007`: Defines a mint event and a mint function for minting AIGC-NFTs. It also includes a verify function to check the validity of a combination of prompt and proof using zkML techniques.

EIPS/eip-7007.md Outdated
Comment on lines 137 to 139
The zkML AIGC-NFTs standard aims to extend the existing [ERC-721](./eip-721.md) token standard to accommodate the unique requirements of AI Generated Content NFTs representing models in a collection. This standard provides interfaces to use zkML to verify whether or not the AIGC data for an NFT is generated from a certain ML model with certain input (prompt). The proposed interfaces allow for additional functionality related to minting, verifying, and enumerating AIGC-NFTs. Additionally, the metadata schema provides a structured format for storing information related to AIGC-NFTs, such as the prompt used to generate the content and the proof of ownership.

With this standard, model owners can publish their trained model and its ZKP verifier to Ethereum. Any user can claim an input (prompt) and publish the inference task, any node that maintains the model and the proving circuit can perform the inference and proving, then submit the output of inference and the ZK proof for the inference trace into the verifier that is deployed by the model owner. The user that initiates the inference task will own the output for the inference of that model and input (prompt).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both of these paragraphs seem more like they belong in the motivation section. The rationale section should explain individual technical decisions made within the EIP itself, while the motivation section should justify the EIP as a whole.

EIPS/eip-7007.md Show resolved Hide resolved
@xinbenlv
Copy link
Contributor

xinbenlv commented Jun 1, 2023

I personally think this EIP snapshot is sufficient for moving to draft. Please update based on @SamWilsn 's editorial suggestion. (For technical peer review feel free to address it in etheruem-magician.org, those peer review comments doesn't block merging into EIP repo.)

@xhyumiracle xhyumiracle dismissed stale reviews from socathie and ghost via 5d5a50a June 7, 2023 04:15
@eth-bot eth-bot added e-review Waiting on editor to review and removed a-review Waiting on author to review labels Jun 7, 2023
@socathie
Copy link

socathie commented Jun 7, 2023

@SamWilsn @xinbenlv We have made some changes. Please review. For the Motivation/Rationale - can we make the changes after merging with an edit PR? It seems to us that based on discussions on ethereum-magician as well as some internal discussions. There might be quite some changes in functionality and hence would drastically change the wording in the Rationale section as well. We would like to do the functional changes first before editing the wording.

Copy link
Contributor

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the Motivation/Rationale - can we make the changes after merging with an edit PR? [...] There might be quite some changes in functionality and hence would drastically change the wording in the Rationale section as well. We would like to do the functional changes first before editing the wording.

@socathie You can just throw the offending paragraphs into the correct sections and then we can merge the draft. Can fix the specific wording and make any technical changes after that.

EIPS/eip-7007.md Outdated
@@ -0,0 +1,160 @@
---
eip: 7007
title: zkML AIGC-NFTs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This title is still a bit too much alphabet soup. How about:

Suggested change
title: zkML AIGC-NFTs
title: Zero-Knowledge AI Generated Content Token

EIPS/eip-7007.md Outdated

## Abstract

The Zero-Knowledge Machine Lerning (zkML) AI Generated Content (AIGC) non-fungible token (NFT) standard is an extension of the [ERC-721](./eip-721.md) token standard for AIGC. It proposes a set of interfaces for basic interactions and enumerable interactions for AIGC-NFTs. The standard includes a new mint event and a JSON schema for AIGC-NFT metadata. Additionally, it incorporates zkML capabilities to enable verification of AIGC-NFT ownership. In this standard, the `tokenId` is indexed by the `prompt`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The Zero-Knowledge Machine Lerning (zkML) AI Generated Content (AIGC) non-fungible token (NFT) standard is an extension of the [ERC-721](./eip-721.md) token standard for AIGC. It proposes a set of interfaces for basic interactions and enumerable interactions for AIGC-NFTs. The standard includes a new mint event and a JSON schema for AIGC-NFT metadata. Additionally, it incorporates zkML capabilities to enable verification of AIGC-NFT ownership. In this standard, the `tokenId` is indexed by the `prompt`.
The Zero-Knowledge Machine Learning (zkML) AI Generated Content (AIGC) non-fungible token (NFT) standard is an extension of the [ERC-721](./eip-721.md) token standard for AIGC. It proposes a set of interfaces for basic interactions and enumerable interactions for AIGC-NFTs. The standard includes a new mint event and a JSON schema for AIGC-NFT metadata. Additionally, it incorporates zkML capabilities to enable verification of AIGC-NFT ownership. In this standard, the `tokenId` is indexed by the `prompt`.

@eth-bot eth-bot changed the title Add EIP: zkML AIGC-NFTs Add EIP: Zero-Knowledge AI-Generated Content Token Jun 10, 2023
@socathie
Copy link

@SamWilsn Thanks for the suggestions. We have updated the title and also moved the paragraphs per your comments. Please check! Thanks.

@eth-bot eth-bot enabled auto-merge (squash) June 19, 2023 20:03
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit bc5433b into ethereum:master Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-new Creates a brand new proposal e-consensus Waiting on editor consensus e-review Waiting on editor to review s-draft This EIP is a Draft t-erc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants