Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EIP: ERC-5219 Resolve Mode #6944

Merged
merged 15 commits into from
May 30, 2023
Merged

Add EIP: ERC-5219 Resolve Mode #6944

merged 15 commits into from
May 30, 2023
+59 −0

Conversation

Pandapip1
Copy link
Member

@Pandapip1 Pandapip1 commented Apr 27, 2023 •
edited
Loading

Wow I really fat fingered that commit message

CC @qizhou

@Pandapip1 Pandapip1 requested a review from eth-bot as a code owner April 27, 2023 17:29
@github-actions github-actions bot added c-new Creates a brand new proposal s-draft This EIP is a Draft t-erc labels Apr 27, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Apr 27, 2023 •
edited
Loading

✅ All reviewers have approved.

@eth-bot eth-bot added e-consensus Waiting on editor consensus e-review Waiting on editor to review labels Apr 27, 2023
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Apr 27, 2023
qizhou
qizhou reviewed May 1, 2023
View reviewed changes
Copy link
Contributor

@qizhou qizhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! One tiny thought I have is whether we should add a few examples of web3:// to a request method? This would help developers to better understand the EIP.

EIPS/eip-erc_5219_resolve_mode.md Outdated Show resolved Hide resolved
Pandapip1 and others added 2 commits May 1, 2023 17:47
@Pandapip1
Update eip-erc_5219_resolve_mode.md
018f05b
@Pandapip1 @abcoathup
Assign EIP number
659ef75 
Co-authored-by: Andrew B Coathup <28278242+abcoathup@users.noreply.github.com>
@github-actions github-actions bot added w-ci Waiting on CI to pass and removed w-ci Waiting on CI to pass labels May 1, 2023
@Pandapip1
Copy link
Member Author

@eth-bot rerun

1 similar comment
@Pandapip1
Copy link
Member Author

@eth-bot rerun

@eth-bot eth-bot changed the base branch from master to eipbot/6944 May 1, 2023 22:08
@eth-bot eth-bot changed the base branch from eipbot/6944 to master May 1, 2023 22:08
@Pandapip1
Copy link
Member Author

@eth-bot rerun

@Pandapip1
Copy link
Member Author

@eth-bot rerun

@eth-bot eth-bot changed the base branch from master to eipbot/6944 May 1, 2023 22:27
@eth-bot eth-bot changed the base branch from eipbot/6944 to master May 1, 2023 22:27
@github-actions github-actions bot added w-ci Waiting on CI to pass and removed w-ci Waiting on CI to pass labels May 1, 2023
qizhou
qizhou previously approved these changes May 2, 2023
View reviewed changes
@Pandapip1 Pandapip1 dismissed stale reviews from ghost and qizhou via 122c332 May 11, 2023 21:09
@github-actions
Copy link

The commit 4f0d67b (as a parent of c056fb2) contains errors.
Please inspect the Run Summary for details.

@qizhou qizhou mentioned this pull request May 29, 2023
Closed
@poojaranjan poojaranjan mentioned this pull request May 30, 2023
Closed
23 tasks
@eth-bot eth-bot enabled auto-merge (squash) May 30, 2023 15:30
eth-bot
eth-bot approved these changes May 30, 2023
View reviewed changes
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

eth-bot
eth-bot approved these changes May 30, 2023
View reviewed changes
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit 7c04c8f into master May 30, 2023
@eth-bot eth-bot deleted the Pandapip1-eip-erc_5219_resolve_mode branch May 30, 2023 15:36
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label May 30, 2023
@Mikhai56 Mikhai56 mentioned this pull request Sep 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qizhou qizhou qizhou left review comments

@abcoathup abcoathup abcoathup left review comments

@SamWilsn SamWilsn SamWilsn approved these changes

@eth-bot eth-bot eth-bot approved these changes

@Mikhai56 Mikhai56 Mikhai56 approved these changes

Assignees
No one assigned
Labels
c-new Creates a brand new proposal e-consensus Waiting on editor consensus e-review Waiting on editor to review s-draft This EIP is a Draft t-erc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Pandapip1 @eth-bot @qizhou @abcoathup @SamWilsn @Mikhai56