-
Notifications
You must be signed in to change notification settings - Fork 5.7k
Description
Pull Request
No response
What happened?
While reviewing EIP-3030, I noticed that a raw BLS secret key is included directly in the test data section:
Secret key: 0x68081afeb7ad3e8d469f87010804c3e8d53ef77d393059a55132637206cc59ec
This is visible at the following line:
Line 138 in ab95f0f
* Secret key: `0x68081afeb7ad3e8d469f87010804c3e8d53ef77d393059a55132637206cc59ec`. |
Ideally, the secret key should be removed or replaced with a generic placeholder like <example_secret_key> or <do_not_use_in_production>, accompanied by a comment indicating that such keys are unsafe to share or reuse, even for demonstration purposes.
Including any form of private key in documentation — even test keys — goes against secure development practices and may unintentionally encourage unsafe behavior. Additionally, this might be misinterpreted or reused by developers unaware of the risks, leading to potential vulnerabilities.
Replace the hardcoded secret key with a generic placeholder
Add a short note or warning about key usage best practices
Optionally relocate full test vectors (if needed) to a secure testing suite outside the EIP document