Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last Call changes must be separate from the PR to move to Final #6129

Closed
xinbenlv opened this issue Dec 13, 2022 · 5 comments
Closed

Last Call changes must be separate from the PR to move to Final #6129

xinbenlv opened this issue Dec 13, 2022 · 5 comments
Labels
enhancement r-process Relates to an EIP Process

Comments

@xinbenlv
Copy link
Contributor

Proposed Change

Shall we consider impose a rule that for when a last-call EIP changes a lot, they shall not go to Final in that same commit and, maybe, revert to Review to give people more time for reviewing the updated version.

This issue was inspired in #6128

@xinbenlv xinbenlv changed the title Propose Policy: Last Call updates shall be separate from Final Propose Policy: Last Call changes shall be separate from the PR to move to Final Dec 13, 2022
@Pandapip1
Copy link
Member

I strongly agree with this. Minor changes can forgo the reset of the last call timer. Major changes should reset it.

@Pandapip1 Pandapip1 changed the title Propose Policy: Last Call changes shall be separate from the PR to move to Final Last Call changes must be separate from the PR to move to Final Dec 14, 2022
@Pandapip1 Pandapip1 added the r-process Relates to an EIP Process label Jan 6, 2023
@ethereum ethereum deleted a comment from tecywiz121 Jan 10, 2023
@github-actions
Copy link

github-actions bot commented Apr 3, 2023

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

@github-actions github-actions bot added the w-stale Waiting on activity label Apr 3, 2023
@Pandapip1
Copy link
Member

@xinbenlv are you making a PR, or should I?

@xinbenlv
Copy link
Contributor Author

xinbenlv commented Apr 3, 2023

I could add it to EIP-1 as a rule (PR #6824). It would be nice if you could make a PR in the eipw or proper bot lint.

@Pandapip1
Copy link
Member

Fixed in #6824.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement r-process Relates to an EIP Process
Projects
None yet
Development

No branches or pull requests

2 participants