-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Last Call changes must be separate from the PR to move to Final #6129
Labels
Comments
xinbenlv
changed the title
Propose Policy: Last Call updates shall be separate from Final
Propose Policy: Last Call changes shall be separate from the PR to move to Final
Dec 13, 2022
I strongly agree with this. Minor changes can forgo the reset of the last call timer. Major changes should reset it. |
10 tasks
Pandapip1
changed the title
Propose Policy: Last Call changes shall be separate from the PR to move to Final
Last Call changes must be separate from the PR to move to Final
Dec 14, 2022
There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity. |
@xinbenlv are you making a PR, or should I? |
I could add it to EIP-1 as a rule (PR #6824). It would be nice if you could make a PR in the eipw or proper bot lint. |
Fixed in #6824. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Proposed Change
Shall we consider impose a rule that for when a last-call EIP changes a lot, they shall not go to Final in that same commit and, maybe, revert to Review to give people more time for reviewing the updated version.
This issue was inspired in #6128
The text was updated successfully, but these errors were encountered: