feat(ops): Consolidate Version Control #8920
Conversation
WalkthroughWalkthroughThe overall change consists of centralizing version control of various tools and dependencies within a project by moving away from multiple configuration files to a single Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
refcell
added
C-feature
refcell
force-pushed
the
refcell/versioning
branch
from
222c856
to
63eeb91
Compare
Not a bad way to go at all. I think that's a perfectly reasonable alternative we can do if others prefer! |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
|
I'm generally in favor of this approach |
|
Other instances of useless cat but not a problem |
refcell
force-pushed
the
refcell/versioning
branch
from
617cc98
to
1e9c633
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
refcell
force-pushed
the
refcell/versioning
branch
from
8dae5fa
to
d673083
Compare
refcell
force-pushed
the
refcell/versioning
branch
from
d673083
to
ac5b77c
Compare
refcell
force-pushed
the
refcell/versioning
branch
from
ac5b77c
to
c61a8fe
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
refcell
force-pushed
the
refcell/versioning
branch
from
c61a8fe
to
96267a3
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Was broken with #8920 due to the new `jq` dependency not being present in the builder image. Fix by installing `jq` in the builder image.
Was broken with #8920 due to the new `jq` dependency not being present in the builder image. Fix by installing `jq` in the builder image.
The foundry install script uses `jq` so we must install `jq` as early as possible in `ci-builder` to ensure that its always present. Follow up to #9042 which fixes the broken build from #8920. I don't think that #8920 broke the fix in this commit so perhaps the build was broken longer than we thought? Either way, we need new forge version in CI that was introduced in #9038 so we need a successful build of `ci-builder`.
The foundry install script uses `jq` so we must install `jq` as early as possible in `ci-builder` to ensure that its always present. Follow up to #9042 which fixes the broken build from #8920. I don't think that #8920 broke the fix in this commit so perhaps the build was broken longer than we thought? Either way, we need new forge version in CI that was introduced in #9038 so we need a successful build of `ci-builder`.
* feat(ops): consolidate version control * fix: remove added slitherrc copy * fix: Makefile geth install target * fix: remove other redundant cat commands * fix: rabbit's suggestion
Was broken with ethereum-optimism#8920 due to the new `jq` dependency not being present in the builder image. Fix by installing `jq` in the builder image.
The foundry install script uses `jq` so we must install `jq` as early as possible in `ci-builder` to ensure that its always present. Follow up to ethereum-optimism#9042 which fixes the broken build from ethereum-optimism#8920. I don't think that ethereum-optimism#8920 broke the fix in this commit so perhaps the build was broken longer than we thought? Either way, we need new forge version in CI that was introduced in ethereum-optimism#9038 so we need a successful build of `ci-builder`.
Description
Historically, binary version control in the monorepo was done via
.<binary>rcfiles that each contain solely the version string for ced binary.Recently, this has become used for an increasing number of binaries, greatly increasing the number of top-level hidden monorepo source files.
This PR consolidates checked in binary versions in a singular top-level
versions.jsonfile where binaries are mapped to their version string or commit hash (for eg foundry).The hidden
rcfiles are now deleted and referencing code has been updated to read and write to the version controlversions.jsonfile.Since this impacts developer use across the monorepo, would appreciate meticulous review and critiques!