Skip to content

fix(kt-devnet): support multiple depsets per devnet #15526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2025
Merged

Conversation

sigma
Copy link
Member

@sigma sigma commented Apr 23, 2025

Description

We now need to support multiple dependency sets within the same devnet.

This change adds room for it, and adjust naming conventions parsing to
accomodate the fact that kurtosis names supervisor instances with the
interop depset.

Tests

Additional context

Metadata

Copy link

codecov bot commented Apr 23, 2025

Codecov Report

Attention: Patch coverage is 70.90909% with 16 lines in your changes missing coverage. Please review.

Project coverage is 42.94%. Comparing base (6d9d43c) to head (98ec6b1).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
kurtosis-devnet/pkg/kurtosis/endpoints.go 76.74% 8 Missing and 2 partials ⚠️
...tosis-devnet/pkg/kurtosis/sources/depset/depset.go 0.00% 5 Missing ⚠️
kurtosis-devnet/pkg/kurtosis/adapters.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #15526      +/-   ##
===========================================
- Coverage    46.83%   42.94%   -3.89%     
===========================================
  Files         1278     1106     -172     
  Lines       105524    95277   -10247     
===========================================
- Hits         49419    40917    -8502     
+ Misses       52625    51052    -1573     
+ Partials      3480     3308     -172     
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?
contracts-bedrock-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
kurtosis-devnet/pkg/kurtosis/kurtosis.go 83.13% <100.00%> (-0.10%) ⬇️
kurtosis-devnet/pkg/kurtosis/adapters.go 0.00% <0.00%> (ø)
...tosis-devnet/pkg/kurtosis/sources/depset/depset.go 0.00% <0.00%> (ø)
kurtosis-devnet/pkg/kurtosis/endpoints.go 85.81% <76.74%> (-4.87%) ⬇️

... and 178 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sigma sigma marked this pull request as ready for review April 23, 2025 17:33
@sigma sigma requested a review from a team as a code owner April 23, 2025 17:33
@sigma sigma requested a review from bitwiseguy April 23, 2025 17:33
@sigma sigma force-pushed the sigma/kt-naming branch from 3d9360d to e6d2d6c Compare April 23, 2025 19:28
@sigma sigma force-pushed the sigma/kt-naming branch from e6d2d6c to 98ec6b1 Compare April 24, 2025 14:54
@sigma sigma added this pull request to the merge queue Apr 24, 2025
Merged via the queue into develop with commit d7af44b Apr 24, 2025
53 checks passed
@sigma sigma deleted the sigma/kt-naming branch April 24, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants