fix: op-batcher batch-tx-submitted metric double count #11438
+0
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
|
I believe this is a good change |
protolambda
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Noticed when playing around with the devnet that the batchtx-submitted metric count was always 2x the nonce of the txmgr, which doesn't make sense.
Realized that
RecordBatchTxSubmittedis called twice:optimism/op-batcher/batcher/channel_manager.go
Line 113 in 5a4fbce
optimism/op-batcher/batcher/channel.go
Line 75 in 5a4fbce
whereas
RecordBatchTxSuccessis never called. So potentially one of the two calls toRecordBatchTxSubmittedshould have been a call toRecordBatchTxSuccessinstead?I just deleted one of them, but probably someone with more context will be able to understand the best fix here. Happy to make any modifications to this PR. :)
Tests
Please describe any tests you've added. If you've added no tests, or left important behavior untested, please explain why not.
Additional context
Add any other context about the problem you're solving.
Metadata