-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Update README.md to describe new ecotone-scalar decode flag #10565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ecotone-scalar was updated in #10547 to support value decoding but didn't include an update to this documentation.
WalkthroughWalkthroughThe recent update to the Changes
Recent Review DetailsConfiguration used: .coderabbit.yml Files selected for processing (1)
Additional comments not posted (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Out of diff range and nitpick comments (4)
op-chain-ops/cmd/ecotone-scalar/README.md (4)
Line range hint
10-10
: Remove the redundant phrase "of".- Inside of `/op-chain-ops`, run: + Inside `/op-chain-ops`, run:
Line range hint
8-8
: Correct the heading level to ensure proper structure.- #### Usage + ## Usage
Line range hint
11-11
: Add a blank line before the fenced code block for better readability.- Build and run using the [Makefile](../../Makefile) `ecotone-scalar` target. Inside `/op-chain-ops`, run: + Build and run using the [Makefile](../../Makefile) `ecotone-scalar` target. Inside `/op-chain-ops`, run:
Line range hint
13-13
: Add a blank line after the fenced code block for better readability.- to create a binary in [../../bin/ecotone-scalar](../../bin/ecotone-scalar) that can + to create a binary in [../../bin/ecotone-scalar](../../bin/ecotone-scalar) that can
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one small request
Semgrep found 1 Detected a network listener listening on 0.0.0.0 or an empty string. This could unexpectedly expose the server publicly as it binds to all available interfaces. Instead, specify another IP address that is not 0.0.0.0 nor the empty string. Ignore this finding from avoid-bind-to-all-interfaces.Semgrep found 1 superfluous nil err check before return Ignore this finding from err-nil-check. |
…-optimism#10565) * Update README.md to describe new ecotone-scalar decode flag ecotone-scalar was updated in ethereum-optimism#10547 to support value decoding but didn't include an update to this documentation. * allow non-decimal scalar values to decode
Description
The ecotone-scalar utility was updated in #10547 to support value decoding but didn't include an update to this documentation.