Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ethereum-optimism/optimism
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 12933236663656526d32db75857dce46c1d3bfa6
Choose a base ref
...
head repository: ethereum-optimism/optimism
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 6578220b35f5b935f2bcf69844eba5e5ebccb4c3
Choose a head ref
  • 5 commits
  • 48 files changed
  • 2 contributors

Commits on Sep 16, 2024

  1. cannon: Implement thread-safe ll and sc operations (#11906) 

    * cannon: Extract RMW op handling from shared logic

* cannon: Add more test cases of LL/SC behavior

* cannon: Cut ll/sc-related logic from common mips code

* cannon: Setup mips helpers to return memory modification info

* cannon: Add new fields to track reserved memory

* cannon: Add a boolean field indicating whether an ll reservation is active

* cannon: Implement ll/sc for MTCannon

* cannon: Add modified sysRead tests for MTCannon

* cannon: Test store operations cleare memory reservations

* cannon: Update SysClockGettime to clear ll memory reservation

* cannon: Fix slither warning - initialize variable

* cannon: Bump MIP2.sol version

* cannon: Run semver, snapshot tasks

* cannon: Cut unused log msg

* cannon: Add new error to MIPS interfaces

* cannon: Cut stale TODO
    @mbaxter
    mbaxter committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    4af1fe6 View commit details
    Browse the repository at this point in the history

  2. Add integration test for apply (#11910) 

    * Add integration test for apply

Adds an integration test for OP Deployer's `apply` method. This test uses Kurtosis to spin up an in-memory L1, deploy the contracts using OP Deployer, then asserts that there is code at all reported addresses.

* Review updates
    @mslipper
    mslipper committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    db10999 View commit details
    Browse the repository at this point in the history

  3. Add integration test for apply 

    Adds an integration test for OP Deployer's `apply` method. This test uses Kurtosis to spin up an in-memory L1, deploy the contracts using OP Deployer, then asserts that there is code at all reported addresses.
    @mslipper
    mslipper committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    40cce84 View commit details
    Browse the repository at this point in the history

  4. Review updates

    @mslipper
    mslipper committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    627ba24 View commit details
    Browse the repository at this point in the history

  5. Port deployers, add end-to-end contract deployments 

    This PR ports over the deployers in `interopgen` into `op-deployer`, and updates `op-deployer` to support end-to end contract deployments for both the Superchain and individual OP Chains.

This PR includes a couple of bugfixes for things I discovered along the way:

1. The script host is updated to bump the nonce of the address calling the CREATE2 deployer when broadcasting. This fixes a chain/simulation mismatch that blocked contracts from being deployed.
2. The DeployImplementations contract used a fixed CREATE2 salt, which caused problems on repeated deployments. I updated the contract to pull the nonce from the environment as we do elsewhere.

Builds on #11910.
    @mslipper
    mslipper committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    6578220 View commit details
    Browse the repository at this point in the history
Loading