Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

miner: fix config unmarshalling #433

Merged
merged 1 commit into from
Nov 21, 2024
Merged

miner: fix config unmarshalling #433

merged 1 commit into from
Nov 21, 2024

Conversation

denis-pingin
Copy link
Contributor

@denis-pingin denis-pingin commented Nov 21, 2024 •
edited
Loading

Description

This fixes an issue with unmarshalling of config.toml created by the dumpconfig command.

Fatal: /persistent/geth/config.toml, line 42: (miner.Config.MaxDATxSize) math/big: cannot unmarshal "<nil>" into a *[big.Int](http://big.int/)
Fatal: /persistent/geth/config.toml, line 42: (miner.Config.MaxDATxSize) math/big: cannot unmarshal "<nil>" into a *[big.Int](http://big.int/)

Additional context

This issue was introduced with changes related to miner.Config.MaxDATxSize

@denis-pingin denis-pingin requested a review from a team as a code owner November 21, 2024 10:46
@protolambda protolambda changed the title Fix dumpconfig unmarshalling miner: fix config unmarshalling Nov 21, 2024
@protolambda protolambda merged commit 23fc614 into ethereum-optimism:optimism Nov 21, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@protolambda protolambda protolambda approved these changes

@sebastianst sebastianst Awaiting requested review from sebastianst sebastianst is a code owner automatically assigned from ethereum-optimism/op-geth-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@denis-pingin @protolambda