core/types/rolloup_cost.go: clarify that the estimated l1 size is scaled up by 1e6 #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastianst
approved these changes
Oct 29, 2024
roberto-bayardo
added a commit
to roberto-bayardo/op-geth
that referenced
this pull request
Oct 29, 2024
roberto-bayardo
added a commit
to roberto-bayardo/op-geth
that referenced
this pull request
Oct 29, 2024
boyuan-chen
pushed a commit
to bobanetwork/op-geth
that referenced
this pull request
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Clarifies that the EstimatedL1Size function actually returns the size in bytes scaled up by 1e6, not the size in bytes, by renaming it appropriately and stating this in the function comment.