skip state db op when NoBaseFee is true #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastianst
approved these changes
Oct 29, 2024
boyuan-chen
pushed a commit
to bobanetwork/op-geth
that referenced
this pull request
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no need to do extra state db operations when NoBaseFee is set and the fee fields are 0.
This PR makes the balance handling for
OptimismBaseFeeRecipientandOptimismL1FeeRecipientconsistent withContext.Coinbase.It'll also save a few cpu cycles for rpc calls like
eth_call/eth_estimate.